Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testdriver.js] Relax test for Actions #13741

Conversation

jugglinmike
Copy link
Contributor

The sequence of actions scheduled within the same tick is undefined.
Relax the test concerning this behavior to reflect the non-determinism.

The sequence of actions scheduled within the same tick is undefined.
Relax the test concerning this behavior to reflect the non-determinism.
@jugglinmike
Copy link
Contributor Author

testdriver.js's "actions" feature is intended to match the corresponding behavior in the W3C WebDriver
specification
. Today, that text is slightly incorrect. I've proposed a fix via w3c/webdriver#1323, and this patch aligns with the new text. We may want to wait to merge this until that pull request is accepted.

@jgraham
Copy link
Contributor

jgraham commented Oct 29, 2018

Eh, I'm concerned by this. Inside an event loop everything has defined ordering and it is fully intended that the actions are scheduled in the order resulting from a transpose of the input array i.e. so that the actions from the first defined device are placed on the event loop first).

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering of actions within a tick is intended to be well-defined and should remain so. The one consession that the webdriver spec makes is that pointerMove of non-zero duration may wait before starting to move, and after the move starts the generated events need not be deterministically ordered, but there's no defined duration in this case, so the order is again well-defined.

@jugglinmike
Copy link
Contributor Author

We addressed this via a change to the spec: w3c/webdriver#1323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants