CSS WPT: Attribute and sibling selectors #14159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2018
Test that attribute selectors are effective when attributes, ids and class lists change. https://drafts.csswg.org/selectors-4/#attribute-selectors Test adjacent and universal sibling selectors when classes change. https://drafts.csswg.org/selectors-4/#adjacent-sibling-combinators https://drafts.csswg.org/selectors-4/#general-sibling-combinators Based on fast/css/invalidation/class-sibling-universal.html (which Blink still needs as it uses internals to count style recalcs). Change-Id: Ia62516e4ab596ef095d4c26a08f90f8f19e5069b Reviewed-on: https://chromium-review.googlesource.com/c/1345371 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#609894}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1345371
branch
from
9546233
to
c3ed7df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that attribute selectors are effective when attributes, ids and
class lists change.
https://drafts.csswg.org/selectors-4/#attribute-selectors
Test adjacent and universal sibling selectors when classes change.
https://drafts.csswg.org/selectors-4/#adjacent-sibling-combinators
https://drafts.csswg.org/selectors-4/#general-sibling-combinators
Based on
fast/css/invalidation/class-sibling-universal.html
(which Blink still needs as it uses internals to count style recalcs).
Change-Id: Ia62516e4ab596ef095d4c26a08f90f8f19e5069b
Reviewed-on: https://chromium-review.googlesource.com/c/1345371
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609894}