Revert "[EventTiming] Move tests to WPT" #14203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f1fb6d618beab1830a086c43acee5c3c1c8d8028. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610504 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjFmYjZkNjE4YmVhYjE4MzBhMDg2YzQzYWNlZTVjM2MxYzhkODAyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: external/wpt/event-timing/event-timing-timingconditions.html Original change's description: > [EventTiming] Move tests to WPT > > This CL moves Event Timing tests to web-platform-tests. Relevant changes: > * Move to using test_driver.click. > * Replace setTimeout with step_timeout. > * Move to using a python-based slow image resource. > > Bug: 841224 > Change-Id: I21f322546815d7d6bcec4dd1703de50a9296d992 > Reviewed-on: https://chromium-review.googlesource.com/c/1348855 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610504} Change-Id: Id18988562dc34b1686497c689605b8436760a10c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841224, 907949 Reviewed-on: https://chromium-review.googlesource.com/c/1348732 Cr-Commit-Position: refs/heads/master@{#610512}
wpt-pr-bot
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f1fb6d618beab1830a086c43acee5c3c1c8d8028.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 610504 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjFmYjZkNjE4YmVhYjE4MzBhMDg2YzQzYWNlZTVjM2MxYzhkODAyOAw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917
Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6
Sample Flaky Test: external/wpt/event-timing/event-timing-timingconditions.html
Original change's description:
Change-Id: Id18988562dc34b1686497c689605b8436760a10c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 841224, 907949
Reviewed-on: https://chromium-review.googlesource.com/c/1348732
Cr-Commit-Position: refs/heads/master@{#610512}