Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tests and remove obsolete ones as per PR13499 #14419

Closed

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Dec 7, 2018

This PR takes changes from PR #13499 and regroup the newly added files and removed files.

@youennf
Copy link
Contributor Author

youennf commented Dec 7, 2018

PR not ready to be merged.
This PR probably requires #14417 and #14418 to be merged first.
This PR probably also needs to remove the files that would not easily run in browser CI

@foolip
Copy link
Member

foolip commented Dec 20, 2018

This PR is blocked on the required "Travis CI - Pull Request" check after #14499. In order to trigger it, I will close and reopen this PR.

@foolip foolip closed this Dec 20, 2018
@foolip foolip reopened this Dec 20, 2018
@alvestrand
Copy link
Contributor

Not ready to merge yet, says @youennf

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

PR for RTCDataChannel-binaryType.html tests uploaded at #16043

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

PR for RTCSctpTransport-onstatechange.html test uploaded at #16044

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

Last test of RTCPeerConnection-close.html is probably redundant with RTCSctpTransport-events.html (once RTCSctpTransport-events.html is removing the last commented check).

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

Other RTCPeerConnection-close.html tests uploaded as a separate PR in #16045

@alvestrand
Copy link
Contributor

Supplanted by single-file test submissions.

@alvestrand alvestrand closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants