Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTCSctpTransport-onstatechange.html test from PR13499 #16044

Closed
wants to merge 1 commit into from
Closed

Add RTCSctpTransport-onstatechange.html test from PR13499 #16044

wants to merge 1 commit into from

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Mar 24, 2019

No description provided.

@youennf youennf mentioned this pull request Mar 24, 2019
Closed
@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

@lgrahl, made some changes to the original test. PTAL.

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

Maybe we should move that test to RTCSctpTransport-events.html

@youennf
Copy link
Contributor Author

youennf commented Mar 24, 2019

Actually, maybe this is redundant with RTCSctpTransport-events.html

@lgrahl
Copy link

lgrahl commented Mar 24, 2019

Agree that it should be moved. It's mostly redundant but RTCSctpTransport-events.html doesn't test for connecting.

lgrahl
lgrahl suggested changes Mar 24, 2019
View reviewed changes
Copy link

@lgrahl lgrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this test works without delaying the connection establishment (due to holding back ICE candidates).

@youennf
Copy link
Contributor Author

youennf commented Mar 28, 2019

Agree that it should be moved. It's mostly redundant but RTCSctpTransport-events.html doesn't test for connecting.

Well it does test for connecting in the first test and for connected in the second test.
I am closing this PR in favor of RTCSctpTransport-events.html.

I don't believe this test works without delaying the connection establishment (due to holding back ICE candidates).

Indeed!

@youennf youennf closed this Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrahl lgrahl lgrahl requested changes

@agouaillard agouaillard Awaiting requested review from agouaillard

@alvestrand alvestrand Awaiting requested review from alvestrand

@guidou guidou Awaiting requested review from guidou

@henbos henbos Awaiting requested review from henbos

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@rwaldron rwaldron Awaiting requested review from rwaldron

@snuggs snuggs Awaiting requested review from snuggs

Assignees

@alvestrand alvestrand

Labels
webrtc wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youennf @lgrahl @alvestrand @wpt-pr-bot