Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create portals/ directory and metadata. #14569

Merged
merged 1 commit into from Dec 18, 2018

Conversation

jeremyroman
Copy link
Contributor

We might as well land some of our tests upstream and write them in WPT style from the get go since we intend for this feature to be on the standards track.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@jeremyroman
Copy link
Contributor Author

@foolip PTAL? @Hexcles suggested I ask you to review this.

@lucasgadani @a4sriniv fyi

@Ms2ger Ms2ger merged commit c3483ef into web-platform-tests:master Dec 18, 2018
@foolip
Copy link
Member

foolip commented Dec 18, 2018

@jeremyroman, LGTM, and thanks for flying with web-platform-tests!

@Hexcles
Copy link
Member

Hexcles commented Dec 18, 2018

@foolip I think we also need to invite @jeremyroman and @lucasgadani to the org and add them to reviewers?

@foolip
Copy link
Member

foolip commented Dec 18, 2018

@Hexcles done! @jeremyroman @lucasgadani see https://github.com/orgs/web-platform-tests/teams/reviewers/discussions for some things you'll want to after you accept the invite to not get lots of email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants