Support pen inputs in web platform tests #14589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 18, 2018
foolip
force-pushed
the
chromium-export-cl-1381144
branch
from
001a7ca
to
ea717e8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1381144
branch
4 times, most recently
from
44f7734
to
b5ef37f
Compare
Because pen inputs are very similar to mouse inputs, for now, we use mouse events to represent pen events with pointer type of "pen". Bug: chromedriver:1897 Change-Id: I0c830f65a1f1bdf1bc6d4a5ef042fc333d18d4ca Reviewed-on: https://chromium-review.googlesource.com/c/1381144 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#619474}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1381144
branch
from
b5ef37f
to
6a9f9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because pen inputs are very similar to mouse inputs, for now, we use
mouse events to represent pen events with pointer type of "pen".
Bug: chromedriver:1897
Change-Id: I0c830f65a1f1bdf1bc6d4a5ef042fc333d18d4ca
Reviewed-on: https://chromium-review.googlesource.com/c/1381144
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619474}