Import WPT fraction tests from WebKit #15301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugs.webkit.org/show_bug.cgi?id=194436 Tests have been reformated and rewritten. The following are excluded: - Tests have equivalent (and more reliable testing) in WPT. - Tests that verify crashs/asserts, hangs or invalid markup.
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Ms2ger
reviewed
Feb 11, 2019
mathml/presentation-markup/fractions/frac-linethickness-003-ref.html
Outdated
Show resolved
Hide resolved
rwlbuis
approved these changes
Feb 20, 2019
Ms2ger
approved these changes
Feb 20, 2019
caiolima
pushed a commit
to caiolima/webkit
that referenced
this pull request
Feb 27, 2019
https://bugs.webkit.org/show_bug.cgi?id=194436 LayoutTests/imported/w3c: This is just an import of the current MathML WPT tests. It includes fraction tests from WebKit that were exported in [1]. Some test results have whitespace change, due to [2]. [1] web-platform-tests/wpt#15301 [2] web-platform-tests/wpt@e2dd57c Patch by Frederic Wang <fwang@igalia.com> on 2019-02-26 Reviewed by Manuel Rego Casasnovas. * resources/resource-files.json: * web-platform-tests/mathml/META.yml: Added. * web-platform-tests/mathml/OWNERS: Removed. * web-platform-tests/mathml/README.md: * web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-1.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-notref.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-002-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-notref.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log: * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt: * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: * web-platform-tests/mathml/presentation-markup/operators/w3c-import.log: * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: * web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log: * web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-1.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: * web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log: * web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: * web-platform-tests/mathml/presentation-markup/spaces/space-1.html: * web-platform-tests/mathml/presentation-markup/spaces/space-2.html: * web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log: * web-platform-tests/mathml/presentation-markup/tables/table-axis-height-expected.txt: * web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: * web-platform-tests/mathml/presentation-markup/tables/w3c-import.log: * web-platform-tests/mathml/relations/css-styling/display-1.html: * web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt: * web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: * web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt: * web-platform-tests/mathml/relations/css-styling/lengths-3.html: * web-platform-tests/mathml/relations/css-styling/w3c-import.log: * web-platform-tests/mathml/relations/html5-tree/class-2.html: * web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: * web-platform-tests/mathml/relations/html5-tree/display-1.html: * web-platform-tests/mathml/relations/html5-tree/href-click-1.html: * web-platform-tests/mathml/relations/html5-tree/href-click-2.html: * web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html: * web-platform-tests/mathml/relations/html5-tree/w3c-import.log: * web-platform-tests/mathml/relations/text-and-math/w3c-import.log: * web-platform-tests/mathml/tools/utils/w3c-import.log: * web-platform-tests/mathml/tools/w3c-import.log: * web-platform-tests/mathml/w3c-import.log: LayoutTests: We removed some fraction tests that have equivalent WPT tests. Some of them were actually exported from WebKit to WPT in [1] We also move tests for crashes/asserts/hangs to the top mathml/ directory. [1] web-platform-tests/wpt#15301 Patch by Frederic Wang <fwang@igalia.com> on 2019-02-26 Reviewed by Manuel Rego Casasnovas. * mathml/fractions-invalid-expected.html: Moved to parent directory. * mathml/fractions-invalid.html: Ditto. * mathml/mfrac-nested-expected.txt: Ditto. * mathml/mfrac-nested.html: Ditto. * mathml/presentation/fractions-box-expected.html: Removed. This is better tested by WPT tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html. * mathml/presentation/fractions-box.html: Removed. Ditto. * mathml/presentation/fractions-color-expected-mismatch.html: Removed. This is exported as frac-color-001.html. * mathml/presentation/fractions-color.html: Removed. Ditto. * mathml/presentation/fractions-linethickness-expected.html: Removed. Covered by WPT tests frac-linethickness-*.html. * mathml/presentation/fractions-linethickness.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness1.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness2-expected.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness2.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness3.html: Removed. Ditto. * mathml/presentation/fractions-mrow-expected.html: Removed. Exported as frac-mrow-001.html. * mathml/presentation/fractions-mrow.html: Removed. Ditto. * mathml/presentation/fractions-numalign-denomalign-expected.html: Removed. Exported as frac-numalign-denomalign-001.html. * mathml/presentation/fractions-numalign-denomalign.html: Removed. Ditto. * mathml/presentation/fractions-vertical-alignment-expected.html: Removed. This is better tests by WPT tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html. * mathml/presentation/fractions-vertical-alignment.html: Removed. Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@242085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
See https://bugs.webkit.org/show_bug.cgi?id=194436 Tests have been reformatted and rewritten. The following are excluded: - Tests have equivalent (and more reliable testing) in WPT. - Tests that verify crashes/asserts, hangs or invalid markup.
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=194436 LayoutTests/imported/w3c: This is just an import of the current MathML WPT tests. It includes fraction tests from WebKit that were exported in [1]. Some test results have whitespace change, due to [2]. [1] web-platform-tests/wpt#15301 [2] web-platform-tests/wpt@e2dd57c Patch by Frederic Wang <fwang@igalia.com> on 2019-02-26 Reviewed by Manuel Rego Casasnovas. * resources/resource-files.json: * web-platform-tests/mathml/META.yml: Added. * web-platform-tests/mathml/OWNERS: Removed. * web-platform-tests/mathml/README.md: * web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-1.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-bar-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001-notref.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-002-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-color-002.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-002.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003-notref.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-linethickness-003.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-mrow-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-numalign-denomalign-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2-expected.txt: * web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: * web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001-expected.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/frac-visibility-001.html: Added. * web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log: * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt: * web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: * web-platform-tests/mathml/presentation-markup/operators/w3c-import.log: * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: * web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log: * web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: * web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-2.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-1.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4-expected.txt: * web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: * web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log: * web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: * web-platform-tests/mathml/presentation-markup/spaces/space-1.html: * web-platform-tests/mathml/presentation-markup/spaces/space-2.html: * web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log: * web-platform-tests/mathml/presentation-markup/tables/table-axis-height-expected.txt: * web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: * web-platform-tests/mathml/presentation-markup/tables/w3c-import.log: * web-platform-tests/mathml/relations/css-styling/display-1.html: * web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt: * web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: * web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt: * web-platform-tests/mathml/relations/css-styling/lengths-3.html: * web-platform-tests/mathml/relations/css-styling/w3c-import.log: * web-platform-tests/mathml/relations/html5-tree/class-2.html: * web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: * web-platform-tests/mathml/relations/html5-tree/display-1.html: * web-platform-tests/mathml/relations/html5-tree/href-click-1.html: * web-platform-tests/mathml/relations/html5-tree/href-click-2.html: * web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html: * web-platform-tests/mathml/relations/html5-tree/w3c-import.log: * web-platform-tests/mathml/relations/text-and-math/w3c-import.log: * web-platform-tests/mathml/tools/utils/w3c-import.log: * web-platform-tests/mathml/tools/w3c-import.log: * web-platform-tests/mathml/w3c-import.log: LayoutTests: We removed some fraction tests that have equivalent WPT tests. Some of them were actually exported from WebKit to WPT in [1] We also move tests for crashes/asserts/hangs to the top mathml/ directory. [1] web-platform-tests/wpt#15301 Patch by Frederic Wang <fwang@igalia.com> on 2019-02-26 Reviewed by Manuel Rego Casasnovas. * mathml/fractions-invalid-expected.html: Moved to parent directory. * mathml/fractions-invalid.html: Ditto. * mathml/mfrac-nested-expected.txt: Ditto. * mathml/mfrac-nested.html: Ditto. * mathml/presentation/fractions-box-expected.html: Removed. This is better tested by WPT tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html. * mathml/presentation/fractions-box.html: Removed. Ditto. * mathml/presentation/fractions-color-expected-mismatch.html: Removed. This is exported as frac-color-001.html. * mathml/presentation/fractions-color.html: Removed. Ditto. * mathml/presentation/fractions-linethickness-expected.html: Removed. Covered by WPT tests frac-linethickness-*.html. * mathml/presentation/fractions-linethickness.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness1.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness2-expected.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness2.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Removed. Ditto. * mathml/presentation/mfrac-linethickness3.html: Removed. Ditto. * mathml/presentation/fractions-mrow-expected.html: Removed. Exported as frac-mrow-001.html. * mathml/presentation/fractions-mrow.html: Removed. Ditto. * mathml/presentation/fractions-numalign-denomalign-expected.html: Removed. Exported as frac-numalign-denomalign-001.html. * mathml/presentation/fractions-numalign-denomalign.html: Removed. Ditto. * mathml/presentation/fractions-vertical-alignment-expected.html: Removed. This is better tests by WPT tests frac-parameters-1.html, frac-parameters-2.html, frac-1.html. * mathml/presentation/fractions-vertical-alignment.html: Removed. Ditto. Canonical link: https://commits.webkit.org/209407@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.webkit.org/show_bug.cgi?id=194436
Tests have been reformated and rewritten.
The following are excluded: