Added calc-serialization-002 getComputedStyle-border-radius-002 tests #15423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
dbaron,
fantasai,
FremyCompany,
frivoal,
plinss and
tabatkins
frivoal
approved these changes
Feb 18, 2019
|
I had a quick phone call with @fantasai friday Feb. 15th. From that short conversation, I am pretty sure that the spec needs to be clearer otherwise clarified. Also from that short conversation, I believe the original intent was that serialization of specified value should not convert absolute length units (cm, in, pc, q, pt) into px unit. Because the web author would certainly want to see his original CSS code remain similar, using the same absolute length units. Anyway, this is my understanding and interpretation. The spec editors have the final word on all this. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 26, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 26, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Feb 27, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
emilio
added a commit
to emilio/servo
that referenced
this pull request
Mar 12, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
emilio
added a commit
to emilio/servo
that referenced
this pull request
Mar 13, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
aditj
pushed a commit
to aditj/servo
that referenced
this pull request
Mar 15, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 43862dc87e0bebd357c300843bc9f2f3eeb0ae41
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 85f7a0580ce94b1d58e63485108fe7ebe54fea2b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 43862dc87e0bebd357c300843bc9f2f3eeb0ae41
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 85f7a0580ce94b1d58e63485108fe7ebe54fea2b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 43862dc87e0bebd357c300843bc9f2f3eeb0ae41
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
The test in web-platform-tests/wpt#15423 hasn't been synced over yet, but it passes with this patch of course. Differential Revision: https://phabricator.services.mozilla.com/D20960 UltraBlame original commit: 85f7a0580ce94b1d58e63485108fe7ebe54fea2b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces pull request 14987
#14987
which corrects and improves the mentioned tests.