Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send screenshots from Azure to wpt.fyi #15765

Merged
merged 1 commit into from Mar 12, 2019
Merged

Send screenshots from Azure to wpt.fyi #15765

merged 1 commit into from Mar 12, 2019

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented Mar 11, 2019

@Hexcles
Copy link
Member Author

Hexcles commented Mar 11, 2019

@foolip the only interesting change is f8774bc

@Hexcles
Copy link
Member Author

Hexcles commented Mar 11, 2019

It works! https://staging.wpt.fyi/results/css/css-flexbox?run_id=5429338749009920&run_id=4762797283999744

I'm going to revert the test change (sorry for spamming all the css reviewers).

@gsnedders
Copy link
Member

Can you make test_end build output as a list and join it at the end?

@Hexcles Hexcles assigned foolip and unassigned mrego Mar 11, 2019
@Hexcles Hexcles removed css-flexbox wg-css wptrunner The automated test runner, commonly called through ./wpt run do not merge yet labels Mar 11, 2019
@Hexcles
Copy link
Member Author

Hexcles commented Mar 11, 2019

@foolip this is ready for review; note that the extension for the screenshot file may be changed following discussions in #15771 for consistency (I don't really like .db, either.), so don't merge it right now.

as wpt_screenshot{_*}.txt in the build artifact zip.
@Hexcles Hexcles merged commit 167e3ee into master Mar 12, 2019
@Hexcles Hexcles deleted the azure-screenshot branch March 12, 2019 22:16
Hexcles added a commit that referenced this pull request Mar 20, 2019
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants