[wptrunner] Detect crash during script execution #16157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2019-03-29, WebDriver does not define expected behavior for cases where the browser crashes during script execution [1]. The type of the value returned by `execute_script` therefore may defy the expectations of subsequent statements, resulting in a Python exception which obscures the reason for the problem. Raise an exception describing a crash to make test results more clear than the Python type-related error that would otherwise occur. [1] w3c/webdriver#1308
wpt-pr-bot
added
infra
wptrunner
gsnedders
approved these changes
Apr 1, 2019
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
As of 2019-03-29, WebDriver does not define expected behavior for cases where the browser crashes during script execution [1]. The type of the value returned by `execute_script` therefore may defy the expectations of subsequent statements, resulting in a Python exception which obscures the reason for the problem. Raise an exception describing a crash to make test results more clear than the Python type-related error that would otherwise occur. [1] w3c/webdriver#1308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2019-03-29, WebDriver does not define expected behavior for cases
where the browser crashes during script execution [1]. The type of the
value returned by
execute_scripttherefore may defy the expectationsof subsequent statements, resulting in a Python exception which obscures
the reason for the problem.
Raise an exception describing a crash to make test results more clear
than the Python type-related error that would otherwise occur.
[1] w3c/webdriver#1308