Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capturing event listeners should be called before non capturing ones #16230

Merged
merged 1 commit into from Apr 5, 2019
Merged

Capturing event listeners should be called before non capturing ones #16230

merged 1 commit into from Apr 5, 2019

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 2, 2019

as per whatwg/dom#685.

@wpt-pr-bot wpt-pr-bot added the dom label Apr 2, 2019
@cdumez
Copy link
Contributor Author

cdumez commented Apr 2, 2019

cc @domenic @rniwa @annevk

@cdumez cdumez mentioned this pull request Apr 2, 2019
Closed
@domenic
Copy link
Member

domenic commented Apr 3, 2019

@Zirro and/or @pmdartus may be able to review this from the perspective of jsdom, which has recently been re-doing its event model to follow the spec and run into similar test/spec mismatches.

annevk
annevk approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this only tested here? I was hoping we'd have more coverage of this.

@annevk
Copy link
Member

annevk commented Apr 5, 2019

This helps whatwg/dom#742.

@cdumez cdumez merged commit e4a98db into web-platform-tests:master Apr 5, 2019
@cdumez cdumez deleted the event_firing_order branch April 5, 2019 15:45
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
Capturing event listeners should be called before non capturing ones (#…
6c8e573 
…16230)

as per whatwg/dom#685.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cdumez @domenic @annevk @zqzhang @wpt-pr-bot