<shadow> should insert original tree's node #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
hayatoito
added a commit
that referenced
this pull request
Jun 8, 2013
<shadow> should insert original tree's node
jgraham
added a commit
that referenced
this pull request
Apr 21, 2017
Increase the timeout for reftests in Firefox-non-e10s-debug.
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 9, 2017
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星🌟星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 9, 2017
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星🌟星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 10, 2017
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星🌟星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581 Reviewed-on: https://chromium-review.googlesource.com/758405 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by: Jungshik Shin <jungshik@google.com> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515425}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Nov 10, 2017
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星🌟星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581 Reviewed-on: https://chromium-review.googlesource.com/758405 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by: Jungshik Shin <jungshik@google.com> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515425}
This was referenced Apr 26, 2022
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if no older shadow tree exists.