[IntersectionObserver] Correctly handle a scaled target #16456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 23, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1578100
branch
3 times, most recently
from
41bc24d
to
004be6a
Compare
If a target is inside an iframe, and the iframe (or one if its ancestors in the parent document) has a scale applied, then we need to apply the scale to the hit test rect when checking for occlusion. The default LocalFrameView coordinate conversion routines don't do that. Use LocalToAncestorQuad instead. BUG=951525 R=chrishtr@chromium.org Change-Id: I1107f0bd3c6d262a392fbafe430897cc09068623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578100 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#653774}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1578100
branch
from
004be6a
to
0fe2d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a target is inside an iframe, and the iframe (or one if its
ancestors in the parent document) has a scale applied, then we need to
apply the scale to the hit test rect when checking for occlusion. The
default LocalFrameView coordinate conversion routines don't do that.
Use LocalToAncestorQuad instead.
BUG=951525
R=chrishtr@chromium.org
Change-Id: I1107f0bd3c6d262a392fbafe430897cc09068623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578100
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653774}