[Gecko Bug 1373835] Make the largest element wider. #16484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 25, 2019 00:16
The right top element is positioned at left:1000px and its width is 600px and the width of the largest element in the content is 2100px. So if the browser window width (precisely documentElement clientWidth) is greater than 1100px, the right top element is not suitable for scroll-snap-align:start, thus some test cases fail. Differential Revision: https://phabricator.services.mozilla.com/D21623 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1373835 gecko-commit: a85948af4c36a697eeb5c60063146b81de06dad2 gecko-integration-branch: central gecko-reviewers: botond
….html. Given the test description is mentioning scrollBy, scrollBy should be used there. Depends on D21623 Differential Revision: https://phabricator.services.mozilla.com/D21624 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1373835 gecko-commit: 9d201f2c32796be22a0defcca7c47cde48a5fd36 gecko-integration-branch: central gecko-reviewers: botond
Depends on D21629 Differential Revision: https://phabricator.services.mozilla.com/D21630 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1373835 gecko-commit: d4682a804eba019aac23fecce0079768a3c6e5cb gecko-integration-branch: central gecko-reviewers: botond
The snap alignment position of the target element is the top left of the target and the position is located out of scroll port (top: -100px, left: -100px). Even so we try to snap a position as much as possible. From the spec [1]; If a snap position is unreachable as specified, such that aligning to it would require scrolling the scroll container’s viewport past the edge of its scrollable overflow region, the used snap position for this snap area is the position resulting from scrolling as much as possible in each relevant axis toward the desired snap position. [1] https://drafts.csswg.org/css-scroll-snap-1/#unreachabLe Depends on D21630 Differential Revision: https://phabricator.services.mozilla.com/D21631 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1373835 gecko-commit: 29466eb6ee253cfd9eb21d6cf6e8d31a0bdd0c6d gecko-integration-branch: central gecko-reviewers: botond
wpt-pr-bot
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right top element is positioned at left:1000px and its width is 600px and
the width of the largest element in the content is 2100px. So if the browser
window width (precisely documentElement clientWidth) is greater than 1100px, the
right top element is not suitable for scroll-snap-align:start, thus some test
cases fail.
Differential Revision: https://phabricator.services.mozilla.com/D21623
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1373835
gecko-commit: a85948af4c36a697eeb5c60063146b81de06dad2
gecko-integration-branch: central
gecko-reviewers: botond