Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1545707] Rework hidden-container-001.html CSS transitions tests #16518

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This behavior is not actually clearly specified yet.

See:

w3c/csswg-drafts#3790

But when it is specified it will most likely be specified in terms of HTML's
"being rendered" definition:

https://html.spec.whatwg.org/#being-rendered

I had planned to specify this behavior before updating these tests but I need to
update them first in order to add the ::marker tests for this bug.

Differential Revision: https://phabricator.services.mozilla.com/D28174

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545707
gecko-commit: 6ccf33c9e56e44937858a86890a65c4296861d98
gecko-integration-branch: central
gecko-reviewers: hiro

This behavior is not actually clearly specified yet.

See:

  w3c/csswg-drafts#3790

But when it is specified it will most likely be specified in terms of HTML's
"being rendered" definition:

  https://html.spec.whatwg.org/#being-rendered

I had planned to specify this behavior before updating these tests but I need to
update them first in order to add the ::marker tests for this bug.

Differential Revision: https://phabricator.services.mozilla.com/D28174

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545707
gecko-commit: 6ccf33c9e56e44937858a86890a65c4296861d98
gecko-integration-branch: central
gecko-reviewers: hiro
In particular, this tests the composite order of ::marker pseudo-elements and
dispatching cancel events for these elements.

It adds one test that is known to fail in Gecko. This will be fixed in the next
patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D28175

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1545707
gecko-commit: bc8f94bb6bb6dad3f71b1ac955f1d89643548013
gecko-integration-branch: central
gecko-reviewers: mats
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@birtles
Copy link
Contributor

birtles commented Apr 25, 2019

It seems odd that taskcluster is reporting a failure for wpt-chrome-dev-stability for CSSTransition-startTime.tentative.html. That test is not touched by this PR.

@jgraham any idea what is going on?

@gsnedders
Copy link
Member

@birtles Does it perhaps include css/css-transitions/support/helper.js? Because that is modified, and that would trigger it.

@gsnedders gsnedders merged commit e8c8501 into master Apr 25, 2019
@gsnedders gsnedders deleted the gecko/1545707 branch April 25, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants