Attempt to handle ChromeDriver versions better #16562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fix (#16454) was insufficient; see https://crbug.com/chromedriver/2656#c21 This time the fix is two-fold: 1. use the tip-of-tree build of ChromeDriver as the final fall back; 2. when running Chrome Dev, disable ChromeDriver's version check (which might make results a bit unreliable when 1 is in effect).
|
This is rather urgent; if anyone gets a chance to approve it, please directly squash-merge the PR (use my PR description as the commit message). Thanks! |
gsnedders
approved these changes
Apr 26, 2019
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
Previous fix (#16454) was insufficient; see https://crbug.com/chromedriver/2656#c21 This time the fix is two-fold: 1. use the tip-of-tree build of ChromeDriver as the final fall back; 2. when running Chrome Dev, disable ChromeDriver's version check (which might make results a bit unreliable when 1 is in effect).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous fix (#16454) was insufficient; see
https://crbug.com/chromedriver/2656#c21
This time the fix is two-fold: 1. use the tip-of-tree build of
ChromeDriver as the final fall back; 2. when running Chrome Dev, disable
ChromeDriver's version check (which might make results a bit unreliable
when 1 is in effect).
This should finally fix #16448.