Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments that were mistakenly abandoned in #16452. #16899

Merged
merged 1 commit into from May 17, 2019
Merged

Address review comments that were mistakenly abandoned in #16452. #16899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 15 additions & 23 deletions sms/constructor.tentative.https.any.js
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

'use strict';

promise_test(async t => {
test(function() {
let used = false;

new SMSReceiver({
Expand All @@ -15,46 +15,38 @@ promise_test(async t => {
assert_true(used, 'constructor options "timeout" member was used');
}, 'constructor uses timeout property');

promise_test(async t => {
try {
test(function() {
assert_throws(new TypeError(), function () {
new SMSReceiver({timeout: 0});
assert_unreached('Timeout 0 should reject');
} catch (error) {
assert_equals(error.name, 'TypeError');
}
});
}, 'constructor throws with invalid timeout (0)');

promise_test(async t => {
try {
test(function() {
assert_throws(new TypeError(), function () {
new SMSReceiver({timeout: null});
assert_unreached('Timeout of null should reject');
} catch (error) {
assert_equals(error.name, 'TypeError');
}
});
}, 'constructor throws with invalid timeout (null)');

promise_test(async t => {
try {
test(function() {
assert_throws(new TypeError(), function () {
new SMSReceiver({timeout: -1});
assert_unreached('Timeout negative numbers should reject');
} catch (error) {
assert_equals(error.name, 'TypeError');
}
});
}, 'constructor throws with invalid timeout (-1)');

promise_test(async t => {
try {
test(function() {
assert_throws(new TypeError(), function () {
new SMSReceiver({timeout: NaN});
assert_unreached('Timeout of NaN should reject');
} catch (error) {
assert_equals(error.name, 'TypeError');
}
});
}, 'constructor throws with invalid timeout (NaN)');

promise_test(async t => {
test(function() {
new SMSReceiver();
}, 'constructor uses a default value for the timeout when none is passed');

promise_test(async t => {
test(function() {
new SMSReceiver({timeout: undefined});
}, 'constructor uses a default value for the timeout');