webrtc wpt: add addIceCandidate(new RTCIceCandidate({candidate, sdpMid})) test #16997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 24, 2019
…d})) test which should have caught the bug BUG=965483 Change-Id: I379f14ee625a9f43889d778b9774bb04949c73af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628722 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#663512}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1628722
branch
from
55ec375
to
1f50fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which should have caught the bug
BUG=965483
Change-Id: I379f14ee625a9f43889d778b9774bb04949c73af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628722
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#663512}