Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation-testcommon.js on Firefox #18508

Merged
merged 1 commit into from Aug 16, 2019

Commits on Aug 16, 2019

  1. Fix interpolation-testcommon.js on Firefox

    The new test generation logic had some problems:
    
      i. It produced different sets of tests on different browsers depending
      on the support status. This caused difficulties comparing test results
      across browsers.
    
      ii. It produced duplicate subtest names when a 'from', 'to', or
      'underlying' was not supported. Duplicate subtests are a fatal error
      in WPT.
    
    This CL fixes these problems by always generating the tests, and
    asserting support in them.
    
    It also removes the composition code, which was unused.
    
    Bug: 900581
    Change-Id: Id5617881bbf3b5f0a0b8eade5b630aa8fd65af8a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758486
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Robert Ma <robertma@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#687797}
    stephenmcgruer authored and chromium-wpt-export-bot committed Aug 16, 2019
    Copy the full SHA
    f221d95 View commit details
    Browse the repository at this point in the history