[css-writing-mode] Fix reftests #18527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reftests were correct with regards to size calculations, but different writing modes align the viewport's scrollbar differently, and unless we compensate for that, thigns won't line up and ref-tests will fail.
frivoal
force-pushed
the
fix-wm-alignment
branch
from
cf7e6a7
to
6c759b7
Compare
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
The reftests were correct with regards to size calculations, but different writing modes align the viewport's scrollbar differently, and unless we compensate for that, thigns won't line up and ref-tests will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reftests were correct with regards to size calculations,
but different writing modes align the viewport's scrollbar differently,
and unless we compensate for that, thigns won't line up and ref-tests
will fail.