Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setTimeout with step_timeout in inert/ tests #18541

Merged
merged 1 commit into from Aug 27, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Aug 19, 2019

This avoids the need to silence the lint.

This avoids the need to silence the lint.
@foolip
Copy link
Member Author

foolip commented Aug 27, 2019

@Hexcles care to review?

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foolip foolip merged commit baa77c7 into master Aug 27, 2019
@foolip foolip deleted the foolip/inert-setTimeout branch August 28, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants