[wptserve] Support .sub. filename w/pipe param
#18623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The substitution feature may be enabled using a filename pattern (`.sub`) or a query string parameter (`pipe=sub`). Prior to this commit, the former approach could not be used if any other "pipe" commands were included in the query string. Update wptserve to interpret the `.sub.` filename pattern as though it were expressed as the first "pipe" command in the query string.
jgraham
approved these changes
Aug 23, 2019
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The substitution feature may be enabled using a filename pattern
(
.sub) or a query string parameter (pipe=sub). Prior to this commit,the former approach could not be used if any other "pipe" commands were
included in the query string. Update wptserve to interpret the
.sub.filename pattern as though it were expressed as the first "pipe" command
in the query string.