[Gecko Bug 1570759] Enable the optimization to not flush for fixed margin values. #18771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted this changes behavior, but it's unclear per w3c/csswg-drafts#2328 what behavior is correct, and our behavior is inconsistent depending on whether there's any percentage involved. This matches other browsers so it's pretty low risk I'd say. The test starts passing without changes to the test, but given the CSSWG issue I made the test not rely on the optimization. Differential Revision: https://phabricator.services.mozilla.com/D43754 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1570759 gecko-commit: 7fa833ff0b1c7880dbba9cd9b6014ad88bed5b67 gecko-integration-branch: autoland gecko-reviewers: jwatt
wpt-pr-bot
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted this changes behavior, but it's unclear per
w3c/csswg-drafts#2328 what behavior is correct, and
our behavior is inconsistent depending on whether there's any percentage
involved.
This matches other browsers so it's pretty low risk I'd say.
The test starts passing without changes to the test, but given the CSSWG issue I
made the test not rely on the optimization.
Differential Revision: https://phabricator.services.mozilla.com/D43754
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1570759
gecko-commit: 7fa833ff0b1c7880dbba9cd9b6014ad88bed5b67
gecko-integration-branch: autoland
gecko-reviewers: jwatt