[LayoutNG] Allow floats to be placed "before" other floats of the same type. #19235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 23, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1819356
branch
2 times, most recently
from
20bee75
to
a943734
Compare
…e type. Floats have some "interesting" behaviour which allows a left (or right) float to be placed left (or right) of a previous float. This typically isn't allowed. This occurs when a float has "negative size" e.g. it has a large negative margin, which is larger than its width. E.g. <div style="width: 50px; margin-left: -150px; float: left;"></div> In such cases the float doesn't respect the normal rules, and is placed in a typically invalid area. This patch also changes "const LogicalSize& minimum_size" to "const LayoutUnit minimum_inline_size" for "FindLayoutOpportunity". Bug: 1005437 Change-Id: I4c91a53911b2651346487f71c4b31ec6e0240202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819356 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#699390}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1819356
branch
from
a943734
to
519961d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floats have some "interesting" behaviour which allows a left (or right)
float to be placed left (or right) of a previous float. This typically
isn't allowed.
This occurs when a float has "negative size" e.g. it has a large
negative margin, which is larger than its width. E.g.
<div style="width: 50px; margin-left: -150px; float: left;"></div>
In such cases the float doesn't respect the normal rules, and is
placed in a typically invalid area.
This patch also changes "const LogicalSize& minimum_size" to
"const LayoutUnit minimum_inline_size" for "FindLayoutOpportunity".
Bug: 1005437
Change-Id: I4c91a53911b2651346487f71c4b31ec6e0240202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819356
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699390}