Restrict 'keySplines' x-values to the [0, 1] range #19248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 24, 2019
Per SMIL[1], all the values in a key spline should be within [0, 1], but to be consistent with CSS' timing function, allow y-values to be outside that range (at least for now). While in ParseKeySplinesInternal(...), rename the |pos_*| local variables to something that carries a little bit more semantic meaning. [1] https://www.w3.org/TR/SMIL3/smil-animation.html#adef-keySplines Bug: 1006544 Change-Id: I6baa4085943eca8144605fb0a5c442bc8486ad87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821158 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#699373}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1821158
branch
from
250dabe
to
7e61096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SMIL[1], all the values in a key spline should be within [0, 1], but
to be consistent with CSS' timing function, allow y-values to be outside
that range (at least for now).
While in ParseKeySplinesInternal(...), rename the |pos_*| local
variables to something that carries a little bit more semantic meaning.
[1] https://www.w3.org/TR/SMIL3/smil-animation.html#adef-keySplines
Bug: 1006544
Change-Id: I6baa4085943eca8144605fb0a5c442bc8486ad87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821158
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#699373}