Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChromeDriver acceptInsecureCerts capability tests #19584

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix ChromeDriver acceptInsecureCerts capability tests #19584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce48ea
Fix ChromeDriver acceptInsecureCerts capability tests
JohnChen0 Oct 8, 2019
376dda1
Fix typo
JohnChen0 Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions webdriver/tests/new_session/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,19 @@ def add_browser_capabilities(capabilities):
return add_browser_capabilities


@pytest.fixture(name="configuration")
def fixture_configuration(configuration):
"""Remove "acceptInsecureCerts" from capabilities if it exists.

Some browser configurations add acceptInsecureCerts capability by default.
Remove it during new_session tests to avoid interference.
"""

if "acceptInsecureCerts" in configuration["capabilities"]:
configuration = dict(configuration)
del configuration["capabilities"]["acceptInsecureCerts"]
return configuration

@pytest.fixture(name="new_session")
def fixture_new_session(request, configuration, current_session):
"""Start a new session for tests which themselves test creating new sessions.
Expand Down