[WebNFC] Rename toText, toJSON, and toArrayBuffer NDEFRecord methods #19667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 14, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1855921
branch
from
ff5b368
to
d15d42b
Compare
This CL renames NDEFRecord methods "toText()" to "text()", "toJSON()" to "json()", and "toArrayBuffer()", to "arrayBuffer() as decided at w3c/web-nfc#370 Change-Id: I8a540ee68b34863e09df562c2075e0d3c786462a Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855921 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#705531}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1855921
branch
from
d15d42b
to
89edd10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL renames NDEFRecord methods "toText()" to "text()", "toJSON()" to
"json()", and "toArrayBuffer()", to "arrayBuffer() as decided at
w3c/web-nfc#370
Change-Id: I8a540ee68b34863e09df562c2075e0d3c786462a
Bug: 520391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855921
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#705531}