Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import statements in wptrunner to be compatible with python3 #19835

Merged
merged 1 commit into from Oct 26, 2019
Merged

Fix import statements in wptrunner to be compatible with python3 #19835

merged 1 commit into from Oct 26, 2019

Conversation

marmeladema
Copy link
Contributor

@marmeladema marmeladema commented Oct 22, 2019 •
edited

Following my work in servo for servo/servo#23607, this commit will help building it using Python3.

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Oct 22, 2019
foolip
foolip approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified we already have a lot of from . import foo and from .foo import bar so this looks good!

@foolip foolip merged commit 5b9df7d into web-platform-tests:master Oct 26, 2019
@foolip foolip changed the title Fix import satements in wptrunner to be compatible with python3 Fix import statements in wptrunner to be compatible with python3 Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marmeladema @foolip @jgraham @wpt-pr-bot