[fetch] Opt-in to single-page test feature #19919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domfarolino,
jdm,
mnot,
youennf and
yutakahirano
|
@annevk can you review this one? I've been reviewing/merging a bunch of these, but I suspect you might have feedback on this one. |
annevk
approved these changes
Oct 28, 2019
foolip
reviewed
Oct 28, 2019
| @@ -31,6 +31,7 @@ <h1 id="header">Header example</h1> | |||
| </body> | |||
|
|
|||
| <script> | |||
| setup({ single_test: true }); | |||
There was a problem hiding this comment.
@jugglinmike I see that this and a few of the following are just sync tests, can you wrap them in test(() => { ... }) instead?
There was a problem hiding this comment.
Sure. I've added titles to those tests, as well
foolip
approved these changes
Oct 28, 2019
|
@jugglinmike I'll leave merging to you as you'll probably want to change the commit message. |
testharness.js was recently extended with an API to explicitly opt-in to the "single page test" feature [1]. As per WPT RFC 28 [2], tests which do not use this API and which do not declare any subtests will soon be reported as a harness error. Update some tests which previously opted in implicitly to use the new API. Update others to instead declare a single subtest (so that they are no longer single-page tests). [1] web-platform-tests#19449 [2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md
jugglinmike
force-pushed
the
single-test-opt-in-fetch
branch
from
85da604
to
80a95a6
Compare
|
Thanks, Philip. I do, indeed. The original version of this branch is available here. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.
Update the tests which previously opted in implicitly to use the new
API.
[1] #19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md