Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerConnection] Update addIceCandidate to use the Operations Chain. #20178

Merged
merged 1 commit into from Nov 13, 2019

Commits on Nov 13, 2019

  1. [PeerConnection] Update addIceCandidate to use the Operations Chain.

    Invoke the callback-based version of AddIceCandidate() recently added in
    third_party/webrtc.
    
    This CL also...
    - Adds WPT test coverage for two separate but related issues relating to
      the timing between SLD and addIceCandidate which may cause edge-case
      race conditions when exchanging ICE candidates. See referenced bugs.
    - Remove old AddIceCandidate code path.
    
    Bug: chromium:1019222, chromium:1019232
    Change-Id: I11d013487325b14739f99617c1d2063a06743524
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906368
    Commit-Queue: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Harald Alvestrand <hta@chromium.org>
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#714925}
    henbos authored and chromium-wpt-export-bot committed Nov 13, 2019
    Copy the full SHA
    beb0776 View commit details
    Browse the repository at this point in the history