Fix paint worklet hidpi #20345
Merged
Fix paint worklet hidpi #20345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1841530
branch
from
5902e21
to
d7add85
Compare
Right now in the PaintRenderingContext2D::setTransform, we account for the device_scale_factor_. This is wrong. It appears that internally the recording canvas handles the device scale factor in the correct way. Instead it should account for browser zoom. A layout test has been changed to expect the correct result. Screen recordings here to show that the demo is rendered correctly: https://drive.google.com/drive/folders/1NbHlFgxBvJDvtN3wrq61uyzzIPk83FXR?usp=sharing Bug: 970783 Change-Id: I8f2b6287fe5b0c443d7de5c8c61bfb62ae1ef42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841530 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#717322}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1841530
branch
from
d7add85
to
01e6d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in the PaintRenderingContext2D::setTransform, we account for
the device_scale_factor_. This is wrong. It appears that internally
the recording canvas handles the device scale factor in the correct way.
Instead it should account for browser zoom.
A layout test has been changed to expect the correct result.
Screen recordings here to show that the demo is rendered correctly:
https://drive.google.com/drive/folders/1NbHlFgxBvJDvtN3wrq61uyzzIPk83FXR?usp=sharing
Bug: 970783
Change-Id: I8f2b6287fe5b0c443d7de5c8c61bfb62ae1ef42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841530
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717322}