Test that MediaQueryList extends EventTarget #20401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jdm
approved these changes
Nov 22, 2019
zcorpan
requested changes
Nov 22, 2019
shvaikalesh
commented
Nov 23, 2019
| @@ -48,7 +48,7 @@ | |||
| triggerMQLEvent(mql); | |||
| await waitForChangesReported(); | |||
|
|
|||
| assert_true(_event instanceof MediaQueryListEvent); | |||
There was a problem hiding this comment.
This assertion was incorrect because mql is from another Realm.
shvaikalesh
commented
Nov 24, 2019
| @@ -159,10 +159,10 @@ | |||
|
|
|||
| triggerMQLEvent(mql); | |||
| await waitForChangesReported(); | |||
| assert_array_equals(calls, ["addListener", "addEventListener"], "triggerMQLEvent"); | |||
There was a problem hiding this comment.
Please see #20423.
zcorpan
approved these changes
Nov 25, 2019
|
Firefox fails some subtests in MediaQueryList-extends-EventTarget-interop.html , is there a bug filed for that? |
zcorpan
pushed a commit
that referenced
this pull request
Jan 22, 2020
* Make sure "handleEvent" property is looked up * Extract `uncaught_error_test` helper WebKit issue: https://bugs.webkit.org/show_bug.cgi?id=203288 Follow-up of #15105 and #20401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit issue: MediaQueryList should extend EventTarget.
Related: #19841, #18390, #18389.
//cc @zcorpan, @jdm