[WebNFC] Add permission prompt for NDEFReader.scan #20402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 22, 2019
This CL makes sure NDEFReader.scan shows a permission request if user didn't previously allow Web NFC. Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8 Bug: 520391 Change-Id: I10125c8db9a4b1cdd3476939bdf650583c7f19b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930823 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#718143}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1930823
branch
from
ddd9131
to
c899500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes sure NDEFReader.scan shows a permission request if user
didn't previously allow Web NFC.
Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8
Bug: 520391
Change-Id: I10125c8db9a4b1cdd3476939bdf650583c7f19b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930823
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#718143}