Fetch Metadata: Assert portal support for WPT. #20429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 25, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1932782
branch
from
f7776db
to
c1feb34
Compare
The portal tests are timing out on wpt.fyi because portals aren't behind the experimental web platform test flag. This patch adds an `assert_precondition` call to ensure that we're not waiting around for a test that will never pass. Change-Id: I6541460d5116de411fe30956d56b41d4d773e106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932782 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#718641}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1932782
branch
from
c1feb34
to
a9f4bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portal tests are timing out on wpt.fyi because portals aren't behind
the experimental web platform test flag. This patch adds an
assert_preconditioncall to ensure that we're not waiting around for atest that will never pass.
Change-Id: I6541460d5116de411fe30956d56b41d4d773e106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932782
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718641}