Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Set Permission API to testdriver.js #20461

Merged
merged 4 commits into from Dec 3, 2019
Merged

Add Set Permission API to testdriver.js #20461

merged 4 commits into from Dec 3, 2019

Conversation

LukeZielinski
Copy link
Contributor

This should address issue #5671

@LukeZielinski LukeZielinski marked this pull request as ready for review November 27, 2019 18:44
@wpt-pr-bot wpt-pr-bot added infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run labels Nov 27, 2019
foolip
foolip reviewed Nov 28, 2019
View reviewed changes
infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
tools/wptrunner/wptrunner/executors/base.py Outdated
descriptor = permission_params["descriptor"]
name = descriptor["name"]
state = permission_params["state"]
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False
one_realm = permission_params.get("oneRealm", False)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work, not tested...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
LukeZielinski
LukeZielinski commented Nov 28, 2019
View reviewed changes
Copy link
Contributor Author

@LukeZielinski LukeZielinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @foolip

infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
infrastructure/testdriver/set_permission.html Outdated Show resolved Hide resolved
tools/wptrunner/wptrunner/executors/base.py Outdated
descriptor = permission_params["descriptor"]
name = descriptor["name"]
state = permission_params["state"]
one_realm = permission_params["oneRealm"] if "oneRealm" in permission_params else False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@LukeZielinski
Copy link
Contributor Author

Rebased and addressed comments. Only remaining failures are stability checks timing out, as expected. @foolip ping?

@foolip
Copy link
Member

foolip commented Dec 3, 2019

Looks like there were 403 affected tests, which is consistent with Taskcluster stability check timeouts. I'll admin merge.

@foolip foolip merged commit 302caa8 into web-platform-tests:master Dec 3, 2019
This was referenced Dec 3, 2019
Closed
Closed
@rakuco rakuco mentioned this pull request Dec 9, 2019
Closed
@LukeZielinski LukeZielinski deleted the testdriver-permissions branch February 19, 2020 16:30
chromium-wpt-export-bot pushed a commit that referenced this pull request Apr 30, 2020
@chromium-wpt-export-bot
Clipboard API Tests: Automate Web Platform Tests
b002cd1 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Apr 30, 2020
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request May 4, 2020
@chromium-wpt-export-bot
Clipboard API Tests: Automate Web Platform Tests
c7f1f5a 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}
pull bot pushed a commit to Yannic/chromium that referenced this pull request May 4, 2020
Clipboard API Tests: Automate Web Platform Tests
59c99fc 
Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}
Hexcles pushed a commit that referenced this pull request May 14, 2020
@Hexcles
Clipboard API Tests: Automate Web Platform Tests
957c333 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}
chromium-wpt-export-bot pushed a commit that referenced this pull request May 14, 2020
@chromium-wpt-export-bot
Clipbooard API Tests: Move permissions tests to WPT.
653b172 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request May 14, 2020
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request May 15, 2020
@chromium-wpt-export-bot
Clipboard API Tests: Move permissions tests to WPT.
27acc7f 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request May 15, 2020
Clipboard API Tests: Move permissions tests to WPT.
1a94bbf 
Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}
Hexcles pushed a commit that referenced this pull request May 15, 2020
@Hexcles
Clipboard API Tests: Move permissions tests to WPT.
290d036 
Since #20461 and
#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 26, 2020
@moz-wptsync-bot
Bug 1634232 [wpt PR 23332] - Clipboard API Tests: Automate Web Platfo…
9ce3b8a 
…rm Tests, a=testonly

Automatic update from web-platform-tests
Clipboard API Tests: Automate Web Platform Tests

Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}

--

wpt-commits: 957c333350503196cc1bf72cc9f6d8b4fdfc2b2c
wpt-pr: 23332
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 26, 2020
@moz-wptsync-bot
Bug 1638136 [wpt PR 23617] - Clipboard API Tests: Move permissions te…
1a03b5c 
…sts to WPT., a=testonly

Automatic update from web-platform-tests
Clipboard API Tests: Move permissions tests to WPT.

Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}

--

wpt-commits: 290d03696f5008625c2ebd1bfaf37eb9bff5bd79
wpt-pr: 23617
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request May 26, 2020
@moz-wptsync-bot
Bug 1634232 [wpt PR 23332] - Clipboard API Tests: Automate Web Platfo…
282a316 
…rm Tests, a=testonly

Automatic update from web-platform-tests
Clipboard API Tests: Automate Web Platform Tests

Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}

--

wpt-commits: 957c333350503196cc1bf72cc9f6d8b4fdfc2b2c
wpt-pr: 23332
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request May 26, 2020
@moz-wptsync-bot
Bug 1638136 [wpt PR 23617] - Clipboard API Tests: Move permissions te…
8f3a679 
…sts to WPT., a=testonly

Automatic update from web-platform-tests
Clipboard API Tests: Move permissions tests to WPT.

Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}

--

wpt-commits: 290d03696f5008625c2ebd1bfaf37eb9bff5bd79
wpt-pr: 23617
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
Clipboard API Tests: Move permissions tests to WPT.
2859111 
Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#769171}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1a94bbf1dd8464157d2c58a62d1a4ed1fdb03cfb
ns-rsilva pushed a commit to ns-rsilva/chromium that referenced this pull request Apr 25, 2024
Clipboard API Tests: Automate Web Platform Tests
028b6b6 
Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API tests previously were duplicated in non-WPT in order to automate
them via PermissionsHelper and detect regressions.

This allows us to shed a lot of duplicate tests, as well as a difficult-to-remember
process of remembering to update both test suites when changes were made.

Bug: 1076691
Change-Id: Ibdfdf37e75da68d7a4b1e2ba986e4198b73230ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065346
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#764967}

Former-commit-id: 59c99fcd658a705942a2b869cbc796c9bf4f621b
ns-rsilva pushed a commit to ns-rsilva/chromium that referenced this pull request Apr 25, 2024
Clipboard API Tests: Move permissions tests to WPT.
b4142d8 
Since web-platform-tests/wpt#20461 and
web-platform-tests/wpt#5671 were fixed, it now
becomes possible to automate some Web Platform Tests, and have them run
on all browsers automatically.

Clipboard API permission tests were previously outside WPT in order to
automate permissions using PermissionsHelper and detect regressions.

This allows us to share our permissions tests with other browsers
testing using WPT.

Bug: 1076691
Change-Id: I1ff6a8bbdf60b8d77fd8621efce840739fbeec23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200278
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769171}

Former-commit-id: 1a94bbf1dd8464157d2c58a62d1a4ed1fdb03cfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

@foolip foolip

Labels
infra testdriver.js wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LukeZielinski @foolip @jgraham @wpt-pr-bot @moz-wptsync-bot