Workaround occasional timeout in wpt/svg/animations/cyclic-syncbase-2.html #20583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2019
….html Apparently we sometimes miss to dispatch 'endEvent's, leading to this test timing out. We can switch it to listen for 'beginEvent' instead though with no harm done, so do that. Bug: 1030228 Change-Id: Ie7495d478b0d799fc54b16b45efba9527da222c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948886 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#721004}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1948886
branch
from
57a82a6
to
dd40d87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we sometimes miss to dispatch 'endEvent's, leading to this
test timing out. We can switch it to listen for 'beginEvent' instead
though with no harm done, so do that.
Bug: 1030228
Change-Id: Ie7495d478b0d799fc54b16b45efba9527da222c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948886
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#721004}