Add tests for cookies' Domain attribute.
#20934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 29, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1983228
branch
from
2c8a7ea
to
64e1e02
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1983228
branch
from
64e1e02
to
0c55a8a
Compare
The current WPT suite for cookies' domain attribute is quite broken; we did a bad job porting it. This patch adds tests for the specific case called out in httpwg/http-extensions#238, and described in https://tools.ietf.org/html/rfc6265#section-5.2.3. Change-Id: Ib8614d5834e028cfc093594b22bc7c8cb4f086a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983228 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#728947}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1983228
branch
from
0c55a8a
to
2c6a7a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current WPT suite for cookies' domain attribute is quite broken; we
did a bad job porting it. This patch adds tests for the specific case
called out in httpwg/http-extensions#238,
and described in https://tools.ietf.org/html/rfc6265#section-5.2.3.
Change-Id: Ib8614d5834e028cfc093594b22bc7c8cb4f086a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983228
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728947}