[webnfc] NDEFScanOptions#mediaType being undefined means do not filter #21017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 3, 2020
And the empty string should just match on empty. The spec change: w3c/web-nfc#496 w3c/web-nfc#498 BUG=520391 Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#728813}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1986632
branch
from
bbfc4a4
to
6d2d49e
Compare
|
Failure seems like an unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And the empty string should just match on empty.
The spec change:
w3c/web-nfc#496
w3c/web-nfc#498
BUG=520391
Change-Id: Idae55b976a6fbbdd252f6227cbe13ee50d16269c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986632
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#728813}