Add a test for createImageBitmap inside a worker #21083
Conversation
|
Do you know about https://web-platform-tests.org/writing-tests/testharness.html#multi-global-tests? I would generally recommend writing worker tests that way (or rewrite an existing window test to cover more globals). |
Interesting - in this case, the behaviour is specifically different when in a worker (you can't create an image bitmap from sources that rely on the DOM), so it's easier to write it like this, but I'll bear this in mind in the future. |
|
Note that https://web-platform-tests.org/writing-tests/testharness.html#standalone-workers-tests exists too. |
I was aware of this - in this case, I specifically wanted to have a worker transfer the ImageBitmap back to a non-worker, which I don't think you can do with a standalone worker test(?) |
|
Ah fair, you can't. Sorry for the noise. |
Not at all, I learnt something useful :) |
|
This landed on WebKit in https://bugs.webkit.org/show_bug.cgi?id=205850 |
|
Does that mean we should close this or should we still land it? Is it not being landed because @Cwiiis has no merge rights? Not sure what the status is of this PR. |
|
I thought we'd landed this already - it'd be good for it to be landed, otherwise WebKit will be out of sync and the change will be overwritten if someone happens to update that test. I don't have merge rights to do so. |
|
(I've asked on IRC for someone to give you those rights.) |
This is tested in the offscreen-canvas tests, but not specifically in the ImageBitmap tests. Given that WebKit at least currently supports the latter and not the former (and this may be true of Gecko?), it'd be worthwhile to test it explicitly.
I ran into this as creation of image bitmaps in WebKit asserted when run off the main thread.