[WebNFC] Rename push NDEFWriter method to write #21143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1993805
branch
5 times, most recently
from
6d323e8
to
242e7f5
Compare
Following spec change at w3c/web-nfc#526, this CL renames NDEFWriter.push to NDEFWriter.write and NDEFPushOptions to NDEFWriteOptions. BUG=520391 Change-Id: Icfaec0609e8cb6145eef4f344519e2ff7b04159c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993805 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Leon Han <leon.han@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#731890}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1993805
branch
from
242e7f5
to
30d5270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following spec change at w3c/web-nfc#526, this
CL renames NDEFWriter.push to NDEFWriter.write and NDEFPushOptions to
NDEFWriteOptions.
BUG=520391
Change-Id: Icfaec0609e8cb6145eef4f344519e2ff7b04159c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993805
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#731890}