[Gecko Bug 1610422] part 1. Pull in missing upstream changes for RTCPeerConnection-ondatachannel.html. #21755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…channel.html. It looks like most of the changes from #16038 we have already, except some whitespace bits. Differential Revision: https://phabricator.services.mozilla.com/D60469 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610422 gecko-commit: adfbba5ae5f7acc18ae9866badd0e2a242bc2ee1 gecko-integration-branch: central gecko-reviewers: jgraham
…Channel.html. This is a clean revert of the changes bug 1609859 made to RTCPeerConnection-createDataChannel.html. It's separated out for review ease; these changes are reinstated 2 changesets later. Differential Revision: https://phabricator.services.mozilla.com/D60470 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610422 gecko-commit: ada3f82c018146820be8cef169d5b91ec081ceca gecko-integration-branch: central gecko-reviewers: jgraham
…eateDataChannel.html.
The changes are as follows:
1) Add an id (and a change in the test label) in the test that now ends up
reading:
const channel = pc.createDataChannel('', { negotiated: true, id: 42 });
2) Add some whitespace bits.
3) Removes a bogus test (thus fixing bug 1550497). The test is bogus because
`null` converts to 0 when converting to `unsigned short`, and that's a
perfectly valid id value.
Compared to upstream, that leaves the following local changes:
* Tests for the "id in the unsigned short range, maybe invalid, but
'negotiated' not set" case.
* A clarification for one of the test descriptions.
* Tests for the "id out of the unsigned short range" case.
These changes are upstreamed in #21285
Differential Revision: https://phabricator.services.mozilla.com/D60472
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610422
gecko-commit: 1ceab0b9f948b8bdce771c98d0ab1101b5deeb1d
gecko-integration-branch: central
gecko-reviewers: jgraham
wpt-pr-bot
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like most of the changes from
#16038 we have already, except
some whitespace bits.
Differential Revision: https://phabricator.services.mozilla.com/D60469
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610422
gecko-commit: adfbba5ae5f7acc18ae9866badd0e2a242bc2ee1
gecko-integration-branch: central
gecko-reviewers: jgraham