Improve dirtying algorithm for form validation tests #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/5832 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
CCing @Ms2ger on the advice of @sideshowbarker |
|
@zcorpan Replied to your comment. |
|
OK LGTM. Can you rebase? |
The set_dirty() function in html/semantics/forms/constraints/support/validator.js
makes an empty selection using setSelectionRange() and then
performs document.execCommand("Delete"), apparently assuming
that this is a no-op.
At least in Chrome, that's not the case!
Chrome deletes the last character in the input!
As document.execCommand() is notoriously not well-standardized, unrelated tests
should avoid relying on its behavior in edge cases (such as empty selections).
So the new strategy is to add an extra character to the input's value,
select this character, and then delete this character.
|
@zcorpan Rebased. |
zcorpan
added a commit
that referenced
this pull request
Oct 2, 2015
Improve dirtying algorithm for form validation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set_dirty()function inhtml/semantics/forms/constraints/support/validator.jsmakes an empty selection usingsetSelectionRange()and then performsdocument.execCommand("Delete"), apparently assuming that this is a no-op.At least in Chrome, that's not the case! Chrome deletes the last character in the input!
As
document.execCommand()is notoriously not well-standardized, unrelated tests should avoid relying on its behavior in edge cases (such as empty selections).So the new strategy is to add an extra character to the input's value, select this character, and then delete this character.