[webauthn] WPT - adding port to RP ID should fail #22092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 4, 2020
Relying party IDs are defined as "a registrable domain suffix of or equal to the caller’s origin's effective domain". RP IDs do not include a port. This patch changes the host + port subtests to expect a failure instead of success. Bug: 875444 Change-Id: I0067ebd883612d534df13a555284fe1cdec7424d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088002 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#747289}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2088002
branch
from
5ec25e4
to
be8db26
Compare
|
Firefox timed out, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying party IDs are defined as "a registrable domain suffix of or
equal to the caller’s origin's effective domain". RP IDs do not include
a port.
This patch changes the host + port subtests to expect a failure instead
of success.
Bug: 875444
Change-Id: I0067ebd883612d534df13a555284fe1cdec7424d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088002
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747289}