Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct default expectation for existing mrow test #22226

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

bkardell
Copy link
Contributor

Attempting to match defaults defined in whatwg/html#5248
definitely needs scrutiny..

Attempting to match defaults defined in whatwg/html#5248
definitely needs scrutiny..
@wpt-pr-bot wpt-pr-bot temporarily deployed to wpt-preview-22226 March 12, 2020 20:27 Inactive
Copy link
Contributor

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be better to do it in two PR: (1) testing more linkable elements and then (2) change tabindex. Otherwise it's not easy to figure out what's happening when checking the log history.

The default `.tabIndex` of an mrow should be 0 regardless of when it has an href or not, as a linkable element and matching historical (oddity) of other linkable things in HTML/SVG
@bkardell bkardell changed the title attempt to test updates for default tabindexes/links correct default expectation for existing mrow test Mar 13, 2020
@bkardell bkardell merged commit 6b2fee7 into master Mar 13, 2020
@bkardell bkardell deleted the bkardell-mathml-default-tabindexes branch March 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants