Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-flexbox] Migrate auto-height-with-flex.html to WPT #22404

Merged
merged 1 commit into from Mar 24, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 23, 2020

Relevant links:

  • original WK patch and fix: [1] and [2].
  • W3 discussion that led to both WK and Blink to diverge
    from the spec temporarily (until it got fixed) and match other
    engine's behaviors (eg, Opera, Firefox): [3]

[1] https://bugs.webkit.org/show_bug.cgi?id=116107
[2] http://trac.webkit.org/changeset/150087
[3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752785}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

Relevant links:

- original WK patch and fix: [1] and [2].
- W3 discussion that led to both WK and Blink to diverge
 from the spec temporarily (until it got fixed) and match other
 engine's behaviors (eg, Opera, Firefox): [3]

[1] https://bugs.webkit.org/show_bug.cgi?id=116107
[2] http://trac.webkit.org/changeset/150087
[3] https://lists.w3.org/Archives/Public/www-style/2013May/0350.html

BUG=1063749
R=dgrogan@chromium.org, robertma@chromium.org

Change-Id: I3d2a087875402954b5b96ff011208bb869ed3664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115768
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752785}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2115768 branch from 4037d41 to 0e70232 Mar 24, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 2982ebc into master Mar 24, 2020
13 checks passed
13 checks passed
Azure Pipelines Build #20200324.22 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Community-TC (pull_request) TaskGroup: success
Details
staging.wpt.fyi - chrome[experimental] Chrome results
Details
staging.wpt.fyi - firefox[experimental] Firefox results
Details
staging.wpt.fyi - safari[experimental] Safari results
Details
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2115768 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants