Handle k-rate AudioParam inputs for OscillatorNode #22613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2111412
branch
2 times, most recently
from
368d8ee
to
41a374a
Compare
As with other fixes, use HasSampleAccurateValuesTimeline() to determine if there are sample-accurate values which is either caused by timeline events or connected inputs to the AudioParam. Tests added to handle possible different combinations of a-rate and k-rate frequency and detune AudioParams. Bug: 1015760 Test: k-rate-oscillator-connections.html Change-Id: I0d90d19b3cafbe353bc9495aa7e493bd20eb9e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111412 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758009}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2111412
branch
from
41a374a
to
f18ee8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with other fixes, use HasSampleAccurateValuesTimeline() to determine
if there are sample-accurate values which is either caused by timeline
events or connected inputs to the AudioParam.
Tests added to handle possible different combinations of a-rate and
k-rate frequency and detune AudioParams.
Bug: 1015760
Test: k-rate-oscillator-connections.html
Change-Id: I0d90d19b3cafbe353bc9495aa7e493bd20eb9e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111412
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758009}