Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle k-rate AudioParam inputs for OscillatorNode #22613

Merged
merged 1 commit into from Apr 9, 2020
Merged

Handle k-rate AudioParam inputs for OscillatorNode #22613

merged 1 commit into from Apr 9, 2020

Commits on Apr 9, 2020

  1. Handle k-rate AudioParam inputs for OscillatorNode 

    As with other fixes, use HasSampleAccurateValuesTimeline() to determine
if there are sample-accurate values which is either caused by timeline
events or connected inputs to the AudioParam.

Tests added to handle possible different combinations of a-rate and
k-rate frequency and detune AudioParams.

Bug: 1015760
Test: k-rate-oscillator-connections.html

Change-Id: I0d90d19b3cafbe353bc9495aa7e493bd20eb9e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111412
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758009}
    @chromium-wpt-export-bot
    Raymond Toy authored and chromium-wpt-export-bot committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    f18ee8d View commit details
    Browse the repository at this point in the history