Fix ordering issue within NGBlockLayoutAlgorithm::ComputeMinMaxSizes #22705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 5, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2136885
branch
from
d3704c7
to
0724180
Compare
The DCHECK in the bug was caused by an order-of-operations issue.
Within the following calculation:
max_inline_contribution =
child_sizes.max_size + line_left_inset + line_right_inset;
If:
child_sizes.max_size == LayoutUnit::Max()
line_left_inset == LayoutUnit(1)
line_right_inset == LayoutUnit(-1)
max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1);
This resulted in max_size < min_size.
Bug: 1004060
Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136885
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757094}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2136885
branch
from
0724180
to
1db049b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DCHECK in the bug was caused by an order-of-operations issue.
Within the following calculation:
max_inline_contribution =
child_sizes.max_size + line_left_inset + line_right_inset;
If:
child_sizes.max_size == LayoutUnit::Max()
line_left_inset == LayoutUnit(1)
line_right_inset == LayoutUnit(-1)
max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1);
This resulted in max_size < min_size.
Bug: 1004060
Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136885
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757094}