Commits on Apr 7, 2020

1. Fix ordering issue within NGBlockLayoutAlgorithm::ComputeMinMaxSizes …

   The DCHECK in the bug was caused by an order-of-operations issue.
   Within the following calculation:
   max_inline_contribution =
             child_sizes.max_size + line_left_inset + line_right_inset;
   
   If:
   child_sizes.max_size == LayoutUnit::Max()
   line_left_inset == LayoutUnit(1)
   line_right_inset == LayoutUnit(-1)
   
   max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1);
   
   This resulted in max_size < min_size.
   
   Bug: 1004060
   Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70
   Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136885
   Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
   Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#757094}

   

   bfgeek authored and chromium-wpt-export-bot committed Apr 7, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 1db049b
   • Browse repository at this point

   Copy the full SHA

   1db049b View commit details

   Browse the repository at this point in the history